Allow locking of the seeded admin user #17273
Conversation
oliverguenther
force-pushed
the
feature/disable-seed-admin
branch
4 times, most recently
from
b546504 to
74e514c
Compare
There was a problem hiding this comment.
It does not work as expect. When running the seeding with OPENPROJECT_SEED_ADMIN_USER_ENABLED=false, it fails with non-null violation errors.
ActiveRecord::NotNullViolation:
PG::NotNullViolation: ERROR: null value in column "user_id" of relation "journals" violates not-null constraint
DETAIL: Failing row contains (5, Project, 5, null, , 2024-11-26 08:54:39.66285+00, 1, 2024-11-26 08:54:39.66285+00, Journal::ProjectJournal, 5, {}, ["2024-11-26 08:54:39.66285+00",)).
That's because the admin user creation is skipped, but then this user is expected to exist as it is the author of all created work packages afterward.
This is controlled by Seeder#admin_user in app/seeders/seeder.rb:82.
Apart from that, I proposed some minor changes.
oliverguenther
force-pushed
the
feature/disable-seed-admin
branch
from
75f042a to
e0104a4
Compare
|
@cbliard good catch, thanks. I'd suggest we use the system user in this case. |
oliverguenther
changed the title
|
Now it fails with "Nothing registered with reference :openproject_admin". I noticed that the tests I added leaked some state and made subsequent tests fail. I just fixed it. |
|
And seeding can't work because the assignee is set to the system user (admin user normally) and then some queries are created with assignee filter being that system user, but they can't be saved because there is a validation rule about the assignee filter that forbids non-human assignees. :/ |
|
Why not implement something like |
oliverguenther
force-pushed
the
feature/disable-seed-admin
branch
2 times, most recently
from
e1ed0f9 to
a48cd19
Compare
oliverguenther
force-pushed
the
feature/disable-seed-admin
branch
from
a48cd19 to
834d8c5
Compare
|
@cbliard Minimal seeding could be another use case, but the demo data should remain. I've talked to openDesk, and locking the user after seeding has completed seems like a good alternative. That way, we can still use that user for demo data, but ensure it's not accessible. |
Ticket
https://community.openproject.org/work_packages/59722